I have a question related to girl or boy selection for marriage.

As people say married couples already decided in heaven yet they marriage here in this world so who ever your wife or husband is that is destiny.

In Qur’an "good men have good wife", then why in society we observe that a good girl is married to some gambler or smuggler or a corrupt person?

There is no ayat or Hadith about couples being made in heaven.

Secondly if you are referring to 24:26, it is a wrong translation by most, there is no reference to men and women there. According to our mufasireen, it means that people are good or bad due to their tongue, and good people speak good words, whilst evil people speak evil words. The end of the verse confirms this “Those [good people] are declared innocent of what they [i.e., slanderers] say”.