My daughter has kept a photo of her favorite singer who is a male in her cupboard. Is this permissable? Or I tell her its haram to do so and I ask her to remove keeping in mind she is good in her ibadaat?

It’s not allowed to keep a photo of a singer unless if the singer is a family member or someone leading her to Allah. It’s better to speak to her and explain to her why she should remove it.